alamb opened a new pull request, #20656: URL: https://github.com/apache/datafusion/pull/20656
## Which issue does this PR close? - Follow on to https://github.com/apache/datafusion/pull/20576 ## Rationale for this change Implement suggestions from @kosiew in https://github.com/apache/datafusion/pull/20576#discussion_r2870761276: > Can we add a deterministic tie-breaker in sort_tests (for equal priority) using relative_path, e.g. sort_by_key(|f| (priority, f.relative_path.clone())) to keep run order stable? > > This would also benefit from a small unit test covering: > > prioritized files are first, > non-prioritized files keep deterministic ordering ## What changes are included in this PR? 1. Add deterministic tie breaker so tests are always run in the same order 2. Add a test for the ordering Note that in order to actually write these tests I needed to pull the TestFile and some related logic into its own module ## Are these changes tested? Yes by CI ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
