adriangb commented on code in PR #20631:
URL: https://github.com/apache/datafusion/pull/20631#discussion_r2874816366
##########
benchmarks/src/util/options.rs:
##########
@@ -91,7 +91,15 @@ impl CommonOpt {
pub fn runtime_env_builder(&self) -> Result<RuntimeEnvBuilder> {
let mut rt_builder = RuntimeEnvBuilder::new();
const NUM_TRACKED_CONSUMERS: usize = 5;
- if let Some(memory_limit) = self.memory_limit {
+ // Use CLI --memory-limit if provided, otherwise fall back to
Review Comment:
That only loads the `SessionConfig` options, the memory limit is part of the
`RuntimeEnv` which comes into play via `SessionContext` (`SessionConfig` +
`RuntimeEnv`).
So we'd have to do some refactoring to create `SessionContext::from_env()`
or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
