Omega359 commented on PR #20588: URL: https://github.com/apache/datafusion/pull/20588#issuecomment-3987657072
> This PR doesn't touch the `array_has` codepath at all, and yet the benchmark run claims fairly wide swings (51%, 27%, 25%, etc.) on some of those benchmarks... I wonder if the benchmark setup needs a longer warm up or perhaps more runs to get more reliable results. I've been wondering that myself. That was run on my personal machine, and since benchmarks are largely single threaded I wouldn't expect much variability in the results .. but the numbers do seem off. I'll try another run later, otherwise I can see about running them on my ec2 instance I have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
