alamb opened a new pull request, #20667:
URL: https://github.com/apache/datafusion/pull/20667

   
   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes #.
   
   ## Rationale for this change
   
   Somewhat frequently PRs try and add a dependency (both codewise and 
logically) to datafusion-functions in the datafusion-optimizer crate
   
   This then gets flagged during code review, which is somewhat frustrating 
probably for the submitter as they didn't know. This most recently happened 
here https://github.com/apache/datafusion/pull/20610/changes#r2877698578
   
   Thus let's try and document that attempt in comments
   
   ## What changes are included in this PR?
   
   Add comments to the relevant Cargo.toml file
   
   ## Are these changes tested?
   
   N/A
   ## Are there any user-facing changes?
   
   No this is a development process change only


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to