LucaCappelletti94 commented on PR #2246: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2246#issuecomment-3991054247
I’ve applied the requested changes and force-pushed the branch, so to remove irrelevant clippy changes from the commits. - Replaced the hardcoded parser guard `(dialect_of!(...PostgreSqlDialect))` with a dialect capability method: `Dialect::supports_order_by_using_operator()`, enabled in `PostgreSqlDialect` only. I have also spent a bit of time checking yet again if any other dialects had it, but so far no other dialects support it. - Removed the dedicated `is_valid_order_by_using_operator_symbol` helper and now validate USING operators through existing dialect behavior `(dialect.is_custom_operator_part(...))`, so we don’t duplicate operator-character rules in parser code. - Trimmed the PR scope/history to a single focused commit and removed unrelated nightly clippy code smell fixes - I hadn't realized it was a nightly only rant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
