gabotechs commented on code in PR #20646:
URL: https://github.com/apache/datafusion/pull/20646#discussion_r2879938116
##########
datafusion/substrait/src/logical_plan/consumer/utils.rs:
##########
@@ -797,6 +818,51 @@ pub(crate) mod tests {
Ok(())
}
+ #[test]
+ fn safe_widening_signed_integers() {
+ assert!(is_safe_widening(&DataType::Int8, &DataType::Int16));
+ assert!(is_safe_widening(&DataType::Int8, &DataType::Int32));
+ assert!(is_safe_widening(&DataType::Int8, &DataType::Int64));
+ assert!(is_safe_widening(&DataType::Int16, &DataType::Int32));
+ assert!(is_safe_widening(&DataType::Int16, &DataType::Int64));
+ assert!(is_safe_widening(&DataType::Int32, &DataType::Int64));
+ }
+
+ #[test]
+ fn safe_widening_unsigned_integers() {
+ assert!(is_safe_widening(&DataType::UInt8, &DataType::UInt16));
+ assert!(is_safe_widening(&DataType::UInt8, &DataType::UInt32));
+ assert!(is_safe_widening(&DataType::UInt8, &DataType::UInt64));
+ assert!(is_safe_widening(&DataType::UInt16, &DataType::UInt32));
+ assert!(is_safe_widening(&DataType::UInt16, &DataType::UInt64));
+ assert!(is_safe_widening(&DataType::UInt32, &DataType::UInt64));
+ }
+
+ #[test]
+ fn safe_widening_floats() {
+ assert!(is_safe_widening(&DataType::Float16, &DataType::Float32));
+ assert!(is_safe_widening(&DataType::Float16, &DataType::Float64));
+ assert!(is_safe_widening(&DataType::Float32, &DataType::Float64));
+ }
+
+ #[test]
+ fn narrowing_rejected() {
+ assert!(!is_safe_widening(&DataType::Int64, &DataType::Int32));
+ assert!(!is_safe_widening(&DataType::Int32, &DataType::Int16));
+ assert!(!is_safe_widening(&DataType::Int16, &DataType::Int8));
+ assert!(!is_safe_widening(&DataType::Float64, &DataType::Float32));
+ assert!(!is_safe_widening(&DataType::UInt64, &DataType::UInt32));
+ }
+
+ #[test]
+ fn cross_family_rejected() {
+ assert!(!is_safe_widening(&DataType::Int32, &DataType::UInt64));
+ assert!(!is_safe_widening(&DataType::UInt32, &DataType::Int64));
+ assert!(!is_safe_widening(&DataType::Float32, &DataType::Int64));
+ assert!(!is_safe_widening(&DataType::Int32, &DataType::Float64));
+ assert!(!is_safe_widening(&DataType::Int32, &DataType::Utf8));
+ }
Review Comment:
These tests are not testing much besides that `match` statements in Rust
work. Maybe we can have a higher level test that covers the if condition
instead? something like a hand-crafted (or Claude-crafted) plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
