kazuyukitanimura commented on code in PR #3627:
URL: https://github.com/apache/datafusion-comet/pull/3627#discussion_r2881160554
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/NativeBatchDecoderIterator.scala:
##########
@@ -37,26 +36,19 @@ import org.apache.comet.vector.NativeUtil
*/
case class NativeBatchDecoderIterator(
in: InputStream,
- taskContext: TaskContext,
- decodeTime: SQLMetric)
+ decodeTime: SQLMetric,
+ nativeLib: Native,
+ nativeUtil: NativeUtil,
+ tracingEnabled: Boolean)
extends Iterator[ColumnarBatch] {
private var isClosed = false
private val longBuf = ByteBuffer.allocate(8).order(ByteOrder.LITTLE_ENDIAN)
- private val native = new Native()
- private val nativeUtil = new NativeUtil()
- private val tracingEnabled = CometConf.COMET_TRACING_ENABLED.get()
private var currentBatch: ColumnarBatch = null
private var batch = fetchNext()
import NativeBatchDecoderIterator._
- if (taskContext != null) {
- taskContext.addTaskCompletionListener[Unit](_ => {
- close()
Review Comment:
@mbutrovich is this close get called somewhere else? Just making sure,
because the new code does not have this clause anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
