Blizzara opened a new pull request, #11489:
URL: https://github.com/apache/datafusion/pull/11489

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   ## Rationale for this change
   
   Previously Substrait consumer would, for window functions, look at:
   1. UDAFs
   2. built-in window functions
   3. built-in aggregate functions
   
   That makes it tough to override the built-in window function behavior, as it 
could only be overridden with a UDAF but some window functions don't fit nicely 
into aggregates.
   
   ## What changes are included in this PR?
   
   This change adds UDWFs at the top, so the consumer will look at:
   1. UDWFs
   2. UDAFs
   3. built-in window functions
   4. built-in aggregate functions
   
   This allows us to override any window function as well, and also paves the 
way for moving DF's built-in window funcs into UDWFs.
   
   ## Are these changes tested?
   
   Added a unit test
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to