alamb commented on PR #20505: URL: https://github.com/apache/datafusion/pull/20505#issuecomment-3998477606
> This fixes a bug and I can't immediately think of any bugs this would cause / why this was needed in the first place, and there are no failing tests. Let's move forward with this and if we find a future bug caused by this change we can come back and think of a better way to fix it than the current code which is buggy. Thanks @adriangb -- I will also spend some time trying to research when it came in and why > I think the question is going to be if it still prunes all the same (including stats). I'd guess it should but we also probably added it there for a reason. I'd guess it was me and I did not add a failing test, which is not good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
