ntjohnson1 commented on code in PR #1400: URL: https://github.com/apache/datafusion-python/pull/1400#discussion_r2885817097
########## pyproject.toml: ########## @@ -70,6 +70,9 @@ features = ["substrait"] [tool.pytest.ini_options] asyncio_mode = "auto" asyncio_default_fixture_loop_scope = "function" +addopts = "--doctest-modules" Review Comment: By default the examples in the doc strings aren't executed. There are a few different ways to turn that functionality on and this seemed the least intrusive. I broke down my commits somewhat (besides the giant here are loads of examples). So the first commit allows testing of the examples in the doc strings. Then I ran pytest (which now automatically runs the tests in the doc strings) and fixed the few cases we already had. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
