alamb commented on code in PR #11466:
URL: https://github.com/apache/datafusion/pull/11466#discussion_r1679493595
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -1108,6 +1102,123 @@ impl Unparser<'_> {
}
}
+ fn interval_scalar_to_sql(&self, v: &ScalarValue) -> Result<ast::Expr> {
+ match self.dialect.interval_style() {
+ IntervalStyle::PostgresVerbose => {
+ let wrap_array = v.to_array()?;
+ let Some(result) = array_value_to_string(&wrap_array, 0).ok()
else {
+ return internal_err!(
+ "Unable to convert interval scalar value to string"
+ );
+ };
+ let interval = Interval {
+ value: Box::new(ast::Expr::Value(SingleQuotedString(
+ result.to_uppercase(),
+ ))),
+ leading_field: None,
+ leading_precision: None,
+ last_field: None,
+ fractional_seconds_precision: None,
+ };
+ Ok(ast::Expr::Interval(interval))
+ }
+ // If the interval standard is SQLStandard, implement a simple
unparse logic
+ IntervalStyle::SQLStandard => match v {
+ ScalarValue::IntervalYearMonth(v) => {
+ let Some(v) = v else {
+ return Ok(ast::Expr::Value(ast::Value::Null));
+ };
+ let interval = Interval {
+ value: Box::new(ast::Expr::Value(
+ ast::Value::SingleQuotedString(v.to_string()),
+ )),
+ leading_field: Some(ast::DateTimeField::Month),
+ leading_precision: None,
+ last_field: None,
+ fractional_seconds_precision: None,
+ };
+ Ok(ast::Expr::Interval(interval))
+ }
+ ScalarValue::IntervalDayTime(v) => {
+ let Some(v) = v else {
+ return Ok(ast::Expr::Value(ast::Value::Null));
+ };
+ let days = v.days;
+ let secs = v.milliseconds / 1_000;
+ let mins = secs / 60;
+ let hours = mins / 60;
+
+ let secs = secs - (mins * 60);
+ let mins = mins - (hours * 60);
+
+ let millis = v.milliseconds % 1_000;
+ let interval = Interval {
+ value: Box::new(ast::Expr::Value(
+ ast::Value::SingleQuotedString(format!(
+ "{days} {hours}:{mins}:{secs}.{millis:3}"
+ )),
+ )),
+ leading_field: Some(ast::DateTimeField::Day),
+ leading_precision: None,
+ last_field: Some(ast::DateTimeField::Second),
+ fractional_seconds_precision: None,
+ };
+ Ok(ast::Expr::Interval(interval))
+ }
+ ScalarValue::IntervalMonthDayNano(v) => {
+ let Some(v) = v else {
+ return Ok(ast::Expr::Value(ast::Value::Null));
+ };
+
+ if v.months >= 0 && v.days == 0 && v.nanoseconds == 0 {
+ let interval = Interval {
+ value: Box::new(ast::Expr::Value(
+
ast::Value::SingleQuotedString(v.months.to_string()),
+ )),
+ leading_field: Some(ast::DateTimeField::Month),
+ leading_precision: None,
+ last_field: None,
+ fractional_seconds_precision: None,
+ };
+ Ok(ast::Expr::Interval(interval))
+ } else if v.months == 0
+ && v.days >= 0
+ && v.nanoseconds % 1_000_000 == 0
+ {
+ let days = v.days;
+ let secs = v.nanoseconds / 1_000_000_000;
+ let mins = secs / 60;
+ let hours = mins / 60;
+
+ let secs = secs - (mins * 60);
+ let mins = mins - (hours * 60);
+
+ let millis = (v.nanoseconds % 1_000_000_000) /
1_000_000;
+
+ let interval = Interval {
+ value: Box::new(ast::Expr::Value(
+ ast::Value::SingleQuotedString(format!(
+ "{days} {hours}:{mins}:{secs}.{millis:03}"
+ )),
+ )),
+ leading_field: Some(ast::DateTimeField::Day),
+ leading_precision: None,
+ last_field: Some(ast::DateTimeField::Second),
+ fractional_seconds_precision: None,
+ };
+ Ok(ast::Expr::Interval(interval))
+ } else {
+ not_impl_err!("Unsupported IntervalMonthDayNano scalar
with both Month and DayTime for IntervalStyle::SQLStandard")
+ }
+ }
+ _ => Ok(ast::Expr::Value(ast::Value::Null)),
+ },
+ IntervalStyle::MySQL => {
+ not_impl_err!("Unsupported interval scalar for
IntervalStyle::MySQL")
Review Comment:
Makes sense -- thanks @y-f-u and @sgrebnov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
