timsaucer commented on PR #20705:
URL: https://github.com/apache/datafusion/pull/20705#issuecomment-4000530806
Added unit test. When I revert to the old code I get this failure
```
thread 'session::tests::test_ffi_session' (14035739) panicked at
datafusion/ffi/src/session/mod.rs:658:9:
assertion `left == right` failed
left: "TableOptions { csv: CsvOptions { has_header: None, delimiter: 44,
quote: 34, terminator: None, escape: None, double_quote: None,
newlines_in_values: None, compression: UNCOMPRESSED, compression_level: None,
schema_infer_max_rec: None, date_format: None, datetime_format: None,
timestamp_format: None, timestamp_tz_format: None, time_format: None,
null_value: None, null_regex: None, comment: None, truncated_rows: None },
parquet: TableParquetOptions { global: ParquetOptions { enable_page_index:
true, pruning: true, skip_metadata: true, metadata_size_hint: Some(524288),
pushdown_filters: false, reorder_filters: false, force_filter_selections:
false, schema_force_view_types: true, binary_as_string: false, coerce_int96:
None, bloom_filter_on_read: true, max_predicate_cache_size: None,
data_pagesize_limit: 1048576, write_batch_size: 1024, writer_version: V1_0,
skip_arrow_metadata: false, compression: Some(\"zstd(3)\"), dictionary_enabled:
Some(true), dictionary_page_size_limit:
1048576, statistics_enabled: Some(\"page\"), max_row_group_size: 1048576,
created_by: \"datafusion version 52.2.0\", column_index_truncate_length:
Some(64), statistics_truncate_length: Some(64), data_page_row_count_limit:
20000, encoding: None, bloom_filter_on_write: false, bloom_filter_fpp: None,
bloom_filter_ndv: None, allow_single_file_parallelism: true,
maximum_parallel_row_group_writers: 1,
maximum_buffered_record_batches_per_stream: 2 }, column_specific_options: {},
key_value_metadata: {}, crypto: ParquetEncryptionOptions { file_decryption:
None, file_encryption: None, factory_id: None, factory_options:
EncryptionFactoryOptions { options: {} } } }, json: JsonOptions { compression:
UNCOMPRESSED, compression_level: None, schema_infer_max_rec: None },
current_format: None, extensions: Extensions({}) }"
right: "TableOptions { csv: CsvOptions { has_header: Some(true), delimiter:
44, quote: 34, terminator: None, escape: None, double_quote: None,
newlines_in_values: None, compression: UNCOMPRESSED, compression_level: None,
schema_infer_max_rec: None, date_format: None, datetime_format: None,
timestamp_format: None, timestamp_tz_format: None, time_format: None,
null_value: None, null_regex: None, comment: None, truncated_rows: None },
parquet: TableParquetOptions { global: ParquetOptions { enable_page_index:
true, pruning: true, skip_metadata: true, metadata_size_hint: Some(524288),
pushdown_filters: false, reorder_filters: false, force_filter_selections:
false, schema_force_view_types: true, binary_as_string: false, coerce_int96:
None, bloom_filter_on_read: true, max_predicate_cache_size: None,
data_pagesize_limit: 1048576, write_batch_size: 1024, writer_version: V1_0,
skip_arrow_metadata: false, compression: Some(\"zstd(3)\"), dictionary_enabled:
Some(true), dictionary_page_size_l
imit: 1048576, statistics_enabled: Some(\"page\"), max_row_group_size:
1048576, created_by: \"datafusion version 52.2.0\",
column_index_truncate_length: Some(64), statistics_truncate_length: Some(64),
data_page_row_count_limit: 20000, encoding: None, bloom_filter_on_write: false,
bloom_filter_fpp: None, bloom_filter_ndv: None, allow_single_file_parallelism:
true, maximum_parallel_row_group_writers: 1,
maximum_buffered_record_batches_per_stream: 2 }, column_specific_options: {},
key_value_metadata: {}, crypto: ParquetEncryptionOptions { file_decryption:
None, file_encryption: None, factory_id: None, factory_options:
EncryptionFactoryOptions { options: {} } } }, json: JsonOptions { compression:
UNCOMPRESSED, compression_level: None, schema_infer_max_rec: Some(10) },
current_format: None, extensions: Extensions({}) }"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
