cetra3 opened a new issue, #20714: URL: https://github.com/apache/datafusion/issues/20714
### Is your feature request related to a problem or challenge? Right now the memory accounting in datafusion appears to be inaccurate. Often times if you limit memory within the application, this isn't honoured very well, and looking at the process in `top` or similar, you can see it uses way more RSS than you would expect. ### Describe the solution you'd like There are a few things we probably need to solve this: ## Benchmark Peak Memory We should introduce benchmarks for peak memory on a variety of different query types, so that we can ensure we don't go comically over our memory allowances. There are two ways that I can see this being introduced * Utilise `codspeed` with `--mode memory`: https://github.com/CodSpeedHQ/codspeed?tab=readme-ov-file#memory. This would allow us to run a few `datafusion-cli` like queries against clickhouse benchmarks etc.. * Utilise `dhat-rs` with specific tests for specific queries, ensuring that we don't go above peak memory + some memory slop: I.e, ```rust #[global_allocator] static ALLOC: dhat::Alloc = dhat::Alloc; #[test] fn test() { let _profiler = dhat::Profiler::builder().testing().build(); // run a 1gb limited query here let stats = dhat::HeapStats::get(); dhat::assert_eq!(stats.max_bytes, 1024 * 1024 * 1024 * 1.1); // 1GB + 10% overhead } ``` ## Introduce the Claim API Allow the memory pool in datafusion to use the new pool feature in arrow-rs. Before this is useful, we need to ensure that we can claim full recordbatches. There are two competing PRs that bring us closer to that goal: - https://github.com/apache/arrow-rs/pull/9433 - https://github.com/apache/arrow-rs/pull/8918 I am biased towards my PR of course, but whatever the `arrow-rs` team thinks is appropriate ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
