darmie commented on issue #20324: URL: https://github.com/apache/datafusion/issues/20324#issuecomment-4005812794
> > [@alamb](https://github.com/alamb) [@adriangb](https://github.com/adriangb) Curious to know your thoughts regarding [#20417](https://github.com/apache/datafusion/pull/20417) > > My feeling is it's a special case of the general idea in [#20363](https://github.com/apache/datafusion/pull/20363) and would prefer a system based on metrics and not heuristics (hopefully we can find a metric that encodes this case without special casing it). My current feeling is to focus on [#20481](https://github.com/apache/datafusion/pull/20481) which fixes parallelism, data skew and gives us smaller units to adapt on for [#20363](https://github.com/apache/datafusion/pull/20363) or similar. That said I would understand the view of "let's just merge the fix/improvement" that works and generalize later. I see your point and agree. I think metrics based and parallelism fixes(biased towards morsel parallelism as per Hyper), they would be of great advantage and should still be pursued even if the heuristics approach is merged for quick wins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
