neilconway commented on code in PR #20426:
URL: https://github.com/apache/datafusion/pull/20426#discussion_r2892369063
##########
datafusion/core/tests/sql/unparser.rs:
##########
@@ -107,6 +107,14 @@ struct TestQuery {
/// Collect SQL for Clickbench queries.
fn clickbench_queries() -> Vec<TestQuery> {
+ // q36-q42 compare UInt16 "EventDate" column with date strings like
'2013-07-01'.
+ // With numeric-preferring comparison coercion, these fail because a date
string
+ // can't be cast to UInt16. These queries use ClickHouse conventions where
+ // EventDate is stored as a day-offset integer.
+ //
+ // TODO: fix this
+ const SKIP_QUERIES: &[&str] = &["q36", "q37", "q38", "q39", "q40", "q41",
"q42"];
Review Comment:
I think I have a solution, similar to what we do when we're actually running
the queries -- load the data into a `xyz_raw` table and then define a view
`xyz` that does the appropriate transform, basically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
