kosiew commented on code in PR #1398:
URL:
https://github.com/apache/datafusion-python/pull/1398#discussion_r2903448359
##########
.github/workflows/build.yml:
##########
@@ -73,7 +73,7 @@ jobs:
enable-cache: true
- name: Install dependencies
- run: uv sync --dev --no-install-package datafusion
+ run: uv sync --locked --dev --no-install-package datafusion
Review Comment:
I agree with the direction here, and the pre-commit hook looks good.
But given the PR title says this enforces lockfile consistency in CI, I
think the CI side is incomplete until all uv sync calls use --locked (or the
title/description is narrowed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
