kosiew commented on code in PR #20814:
URL: https://github.com/apache/datafusion/pull/20814#discussion_r2903634276
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -107,14 +121,40 @@ impl CastExpr {
/// The data type to cast to
pub fn cast_type(&self) -> &DataType {
- &self.cast_type
+ self.target_field.data_type()
+ }
+
+ /// Field metadata describing the output column after casting.
+ pub fn target_field(&self) -> &FieldRef {
+ &self.target_field
}
/// The cast options
pub fn cast_options(&self) -> &CastOptions<'static> {
&self.cast_options
}
+ fn is_legacy_target_field(&self) -> bool {
Review Comment:
I'll rename it to `is_default_target_field`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
