iffyio commented on code in PR #2273:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2273#discussion_r2904505181
##########
src/ast/mod.rs:
##########
@@ -6387,6 +6414,74 @@ impl fmt::Display for TruncateTableTarget {
}
}
+/// Target of a PostgreSQL `LOCK TABLE` command
Review Comment:
```suggestion
/// Target of a `LOCK TABLE` command
```
##########
src/ast/mod.rs:
##########
@@ -6387,6 +6414,74 @@ impl fmt::Display for TruncateTableTarget {
}
}
+/// Target of a PostgreSQL `LOCK TABLE` command
+///
+/// Note this is its own struct because `visit_relation` requires an
`ObjectName` (not a `Vec<ObjectName>`)
Review Comment:
```suggestion
```
we can also include a reference to the docs here, so that its easy to find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]