Sevenannn commented on code in PR #11495:
URL: https://github.com/apache/datafusion/pull/11495#discussion_r1680132675
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -45,6 +45,12 @@ pub trait Dialect {
fn interval_style(&self) -> IntervalStyle {
IntervalStyle::PostgresVerbose
}
+
+ // Does the dialect use DOUBLE PRECISION to represent Float64 rather than
DOUBLE?
+ // E.g. Postgres uses DOUBLE PRECISION instead of DOUBLE
+ fn use_double_precision_for_float64(&self) -> bool {
Review Comment:
Hey @alamb , thanks for the feedback! Directly return AST type seems clearer
and more flexible to me. I update the changes in my newest commit, please take
a look when you are available:
* Return `sqlparser::ast::DataType` instead of `bool`
* Change the method name from `use_double_precision_for_float64` to
`float64_ast_dtype`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
