sgrebnov commented on code in PR #11494:
URL: https://github.com/apache/datafusion/pull/11494#discussion_r1680213787
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -45,6 +45,13 @@ pub trait Dialect {
fn interval_style(&self) -> IntervalStyle {
IntervalStyle::PostgresVerbose
}
+
+ // Does the dialect use CHAR to cast Utf8 rather than TEXT?
+ // E.g. MySQL requires CHAR instead of TEXT and automatically produces a
string with
+ // the VARCHAR, TEXT or LONGTEXT data type based on the length of the
string
+ fn use_char_for_utf8_cast(&self) -> bool {
Review Comment:
I see we have [similar PR
](https://github.com/apache/datafusion/pull/11495), we should align on naming:
`utf8_cast_dtype` (this PR) vs `utf8_asf_dtype` (11495) - @alamb - do you have
a preference :) /cc @Sevenannn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
