eirnym commented on issue #1642:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/issues/1642#issuecomment-4032343155

   Sometimes features just got rejected or forgotten. Or maintainers feel 
uneasiness to allow practical, but not-so-pure code (I don't mean AI) into 
their projects. 
   
   Builders and usage from "other side" could be not-so-intended by the authors 
and maintainers of the project, and possible uneasiness could be in "What if a 
person would build and invalid SQL and will blame us for it?" (yes, it's very 
easy to do, and there's no guardrails for that).
   
   * I expect from maintainers ask community to propose solutions for that
   * I expect from possible solution to have at least minimalistic approach, 
e.g. "you can build an SQL statement from the AST, but you need remember about 
these and these things and responsibility lies on your side". 
   * From mimilaisitc approach I expect at least builder interfaces for main 
structures, and some defaults, expecting from a user to fill the rest.
   * Improvement in documentation to educate people when this or that 
field/style is used and what one thing or another mean. E.g what `bool` 
parameter mean in `Value::Number`? Or where and how this operator/quote is 
used. There's multiple example of that across the project.
   
   I don't expect and even discourage, that any of that thing will come in one 
piece, so meta issue(s) would be needed to cover everything


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to