andygrove commented on code in PR #3563:
URL: https://github.com/apache/datafusion-comet/pull/3563#discussion_r2912733950
##########
spark/src/test/scala/org/apache/comet/CometStringExpressionSuite.scala:
##########
@@ -248,6 +249,60 @@ class CometStringExpressionSuite extends CometTestBase {
}
}
+ test("parse_url") {
+ withParquetTable(
+ Seq(
+ ("http://spark.apache.org/path?query=1";, 0),
+ ("https://spark.apache.org/path/to/page?query=1&k2=v2";, 1),
+ ("ftp://user:[email protected]:2121/files?x=1#frag";, 2),
+ (null, 3)),
+ "tbl_parse_url") {
+
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'HOST') FROM
tbl_parse_url")
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'QUERY') FROM
tbl_parse_url")
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'PROTOCOL') FROM
tbl_parse_url")
+ checkSparkAnswerAndOperator(
+ "SELECT parse_url(_1, 'QUERY', 'query'), parse_url(_1, 'QUERY', 'k2')
FROM tbl_parse_url")
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'PATH') FROM
tbl_parse_url")
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'FILE') FROM
tbl_parse_url")
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'REF') FROM
tbl_parse_url")
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'AUTHORITY') FROM
tbl_parse_url")
+ checkSparkAnswerAndOperator("SELECT parse_url(_1, 'USERINFO') FROM
tbl_parse_url")
+ }
+ }
+
+ test("parse_url in ANSI mode (Spark 3.5)") {
+ assume(!isSpark40Plus)
Review Comment:
Why does this test exclude Spark 4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
