mustafasrepo commented on code in PR #11500:
URL: https://github.com/apache/datafusion/pull/11500#discussion_r1680447853
##########
datafusion/functions-aggregate/src/bit_and_or_xor.rs:
##########
@@ -358,6 +358,14 @@ where
Ok(())
}
+ fn retract_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
+ self.update_batch(values)
Review Comment:
Maybe you can add a comment here, stating explicitly inverse of the xor is
itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
