y-f-u opened a new pull request, #11504: URL: https://github.com/apache/datafusion/pull/11504
## Which issue does this PR close? This makes unparser trait `Dialect` easier to work within DataFusion context for federated queries (datafusion-federation). ## Rationale for this change In federated query context, that could be use cases that a dialect needs to be specified for table providers targeting protocol like flight, odbc because the underlying DBMS may have different sql dialect. Without Send + Sync, it can be tricky to pass the config of dialect down into table provider scan/execute method, etc. In current design, the dialect is mostly an empty struct so it's safe to change so. The alternative is to pass a `fn` which create a `Arc<dyn Dialect>` around which doesn't look great. Thoughts? ## What changes are included in this PR? Make Unparser Dialect to be Send + Sync ## Are these changes tested? n/a. I don't think it needs one. ## Are there any user-facing changes? n/a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
