jayendra13 commented on issue #16054:
URL: https://github.com/apache/datafusion/issues/16054#issuecomment-4033409765
Hi @AndreaBozzo, thanks for the heads-up! I think our #20851 actually avoids
the wall(full SLT suit) you are talking about.
#20206 uses unconditional wrapping — every child BinaryExpr gets
parentheses. This changes schema names even when precedence already gives the
correct reading, which is what triggers the optimize_projections mismatches.
What I am doing at #20851 is only adding parentheses when the child operator
has lower precedence than the parent, matching the logic already in the Display
impl for BinaryExpr. So 1 + 2 + 3 stays unchanged (same precedence, no parens
needed), while (1 + 2) * 3 correctly gets them.
So far all 642 optimizer unit tests pass with only 2 snapshot updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
