alamb commented on issue #11413:
URL: https://github.com/apache/datafusion/issues/11413#issuecomment-2232933181
> An example would be
FWIW this implementation of concat would likely perform pretty poorly
compared to a hand written one as it will both create and allocate a new
temporary `String` for each row (and then presumably copy that value into a
final StringArray/LargeStringArray).
```rust
// declare concat
#[function("concat(string, string) -> string")]
#[function("concat(largestring, largestring) -> largestring")]
fn concat(lhs: &str, rhs: &str) -> String {
format!("{}{}", lhs, rhs)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
