ntjohnson1 commented on code in PR #1411: URL: https://github.com/apache/datafusion-python/pull/1411#discussion_r2917145141
########## python/datafusion/functions.py: ########## @@ -491,16 +491,28 @@ def abs(arg: Expr) -> Expr: def acos(arg: Expr) -> Expr: Review Comment: Yes, there is definitely a bit of maintenance trade off between the documentation value and pain if there is a large refactor that requires updating the docs examples. I think there is value to the standalone but am open to opinions on this since I'm not a primary maintainer. My hope is that after the first large landing of these examples this is kind of just a small additional test surface so it's not more cumbersome than updating tests when api changes happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
