martin-g commented on code in PR #1498: URL: https://github.com/apache/datafusion-ballista/pull/1498#discussion_r2917157146
########## ballista/scheduler/Cargo.toml: ########## @@ -34,7 +34,7 @@ required-features = ["build-binary"] [features] build-binary = ["clap", "tracing-subscriber", "tracing-appender", "tracing", "ballista-core/build-binary"] -default = ["build-binary", "substrait"] +default = ["build-binary", "rest-api"] Review Comment: I prefer as minimal builds as possible. So, if you ask **me**, I would not include it as a default. Users who need it could enable it. But it is equally easy to disable the default features and build whenever one needs ... Another reason not to enable the REST API by default is that it is not protected (authenticated). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
