buraksenn opened a new pull request, #20867: URL: https://github.com/apache/datafusion/pull/20867
## Which issue does this PR close? Not closes ## Rationale for this change In https://github.com/apache/datafusion/pull/20780#discussion_r2911482011 @alamb mentioned whether we can remove redundant alias of `count(*) AS count(*)` to `count(*)` and I tried to give this a go. ### I'm not sure about the implications at the moment it would be great to have input on this PR ## What changes are included in this PR? Main changes are in: - order_by.rs: match only top level expressions instead of recursively searching sub expressions (otherwise we may match wrong expressions) - select.rs: strip alias before comparing otherwise we dont use existing alias at all ## Are these changes tested? I've added some tests for alias. Existing tests and plan outputs changed as well you can see in the PR. ## Are there any user-facing changes? Plans will change but not sure if it has impact -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
