andygrove opened a new pull request, #3671: URL: https://github.com/apache/datafusion-comet/pull/3671
## Which issue does this PR close? Closes #2186. ## Rationale for this change The `native_comet` scan implementation was deprecated in 0.9.0 and has been superseded by `native_iceberg_compat` and `native_datafusion`. The `SCAN_NATIVE_COMET` constant and all test code referencing it is dead code that adds maintenance burden and confusion. ## What changes are included in this PR? - Remove `CometConf.SCAN_NATIVE_COMET` constant and its deprecation annotations - Remove `usingLegacyNativeCometScan` helper methods from `CometTestBase` - Remove `ParquetReadV2Suite` class (all tests were already ignored) - Remove 12 ignored/dead tests across 6 test suites that required `SCAN_NATIVE_COMET` - Simplify conditional branches in active tests that checked for `SCAN_NATIVE_COMET` — these now always take the non-legacy path (e.g., `checkSparkAnswerAndOperator` instead of `checkSparkAnswer`) - Remove `assume(usingLegacyNativeCometScan)` guards (always false, so those tests never ran) - Simplify `if (!usingLegacyNativeCometScan)` blocks (always true) - Simplify `hasUnsignedSmallIntSafetyCheck` to remove dead legacy check - Update comments referencing `native_comet` in `CometScanExec` and `Utils` Net result: **-820 lines** of dead code removed across 17 files. ## How are these changes tested? This is a cleanup of deprecated/dead code. All removed tests were either already `ignore`d or guarded by `assume(usingLegacyNativeCometScan)` which always evaluated to false. The remaining test simplifications only remove the else branches that were never executed. Existing CI tests cover the active scan implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
