asolimando commented on code in PR #19957:
URL: https://github.com/apache/datafusion/pull/19957#discussion_r2923949231
##########
datafusion/physical-expr/src/projection.rs:
##########
@@ -660,9 +660,25 @@ impl ProjectionExprs {
}
}
} else {
- // TODO stats: estimate more statistics from expressions
- // (expressions should compute their statistics themselves)
- ColumnStatistics::new_unknown()
+ // TODO: expressions should compute their own statistics
Review Comment:
Resolving as it seems the comments have been considered, and the discussion
will continue in the follow-up PR for `ExpressionAnalyzer`, feel free to
unresolve if you think otherwise.
EDIT: sorry the page didn't refresh and I missed your message. I agree, I
have reverted it in 0e23ef17d, expression-level statistics will be addressed in
a follow-up, this was there just to show-case how one could use it, but not
worth keeping here, thanks again for the reminder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
