asubiotto commented on code in PR #20907: URL: https://github.com/apache/datafusion/pull/20907#discussion_r2924955640
########## datafusion/common/src/nested_struct.rs: ########## @@ -151,7 +156,7 @@ fn cast_struct_column( /// /// # Arguments /// * `source_col` - The source array to cast -/// * `target_field` - The target field definition (including type and metadata) +/// * `target_type` - The target data type to cast to Review Comment: This refactor made sense. `target_field` was not used at all, only its inner `DataType`. There were several callsites that constructed "mock" fields just to be able to call this function with a datatype. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
