askalt commented on PR #20009:
URL: https://github.com/apache/datafusion/pull/20009#issuecomment-4048675594
> > It seems _this_ API can be easily expressed generically using this patch
>
> By "this", do you mean #20337 + a helper can replace this PR (#20009) or
the other way around? We explicitly considered `physical_expressions()` in
#20337 and decided we do _not_ want to go with that API for performance reasons.
I mean the code from this patch:
```rust
fn physical_expressions<'a>(
&'a self,
) -> Option<Box<dyn Iterator<Item = Arc<dyn PhysicalExpr>> + 'a>> {
None
}
```
This method for me does not look obviously worse than current
`apply_expressions`, as it requires the single iterator allocation: it seems it
will be unmesuareble. Actually, I am ok with the API as it described in
https://github.com/apache/datafusion/issues/20899.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
