timsaucer commented on code in PR #1425:
URL:
https://github.com/apache/datafusion-python/pull/1425#discussion_r2927305314
##########
src/lib.rs:
##########
@@ -16,9 +16,9 @@
// under the License.
// Re-export Apache Arrow DataFusion dependencies
-pub use datafusion;
pub use datafusion::{
Review Comment:
It's a change in the nightly `cargo fmt`, probably from the new rust
release. If we do, then we'd need to turn off the `group_imports` and
`imports_granularity` in `rustfmt.toml`. I suppose we could do that and just
have it turned on in the pre-commit. That just means that any contributors who
do have that turned on will end up with more formatting changes than others. Or
we could take those out, but personally I think it does make the repo cleaner.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
