jayzhan211 commented on PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2233508970
> > `optimizers_catch_all_statistics` failed because `aggregate_statictis`
are not checking with UDAF
> > ```rust
> > fn is_min(agg_expr: &dyn AggregateExpr) -> bool {
> > if let Some(expr) =
agg_expr.as_any().downcast_ref::<AggregateFunctionExpr>() {
> > return expr.fun().name() == "MIN"
> > }
> >
> > false
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > ```rust
> > fn is_max(agg_expr: &dyn AggregateExpr) -> bool {
> > if let Some(expr) =
agg_expr.as_any().downcast_ref::<AggregateFunctionExpr>() {
> > return expr.fun().name() == "MAX"
> > }
> >
> > false
> > }
> > ```
>
> This change was issued here
https://github.com/apache/datafusion/pull/11261/files
I don't get it. What is the reason not to check with UDAF?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
