adriangb commented on code in PR #20913:
URL: https://github.com/apache/datafusion/pull/20913#discussion_r2927480661
##########
datafusion/datasource-parquet/src/row_filter.rs:
##########
@@ -448,10 +442,39 @@ impl TreeNodeVisitor<'_> for PushdownChecker<'_> {
.and_then(|a| a.as_any().downcast_ref::<Column>())
{
let return_type = func.return_type();
- if !DataType::is_nested(return_type) {
- if let Some(recursion) =
self.check_struct_field_column(column.name())
- {
- return Ok(recursion);
+
+ if !DataType::is_nested(return_type)
+ || self.is_nested_type_supported(return_type)
+ {
+ // try to resolve all field name arguments to strinrg
literals
+ // if any argument is not a string literal, we can not
determine the exact
Review Comment:
Under what circumstances would `get_field` accept non-string literal
arguments? Would this be a column e.g. `get_field(struct_col, fields_col)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
