2010YOUY01 commented on PR #20868:
URL: https://github.com/apache/datafusion/pull/20868#issuecomment-4051660258
Thank you for the help!
> 3. Should we replace is_builtin() -> bool by origin() -> UDFOrigin?
UDFOrigin would be something like enum { BuiltIn, Spark, UserDefined }. Asking
because it's not clear to me if functions in the datafusion_spark crates should
be considered built-in or not.
I think `origin() -> UDFOrigin` API is better, it allows more flexibility
for other potential usages. For example in the same context, 2 functions with
the same name are registered, they're in different dialect and we want to check
origin at runtime.
I suggest we first wait several days to see if there are other opinions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
