martin-g commented on code in PR #1503:
URL:
https://github.com/apache/datafusion-ballista/pull/1503#discussion_r2929350569
##########
ballista/core/src/config.rs:
##########
@@ -419,6 +427,23 @@ impl BallistaConfig {
v.parse::<f64>().unwrap()
}
}
+ /// sets the configuration value where key starts with ballista
Review Comment:
```suggestion
/// Sets the configuration value where key starts with ballista
```
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -701,8 +701,6 @@ async fn fetch_partition(
let partition_id = location.partition_id.ok_or_else(|| {
DataFusionError::Internal("Received empty partition id".to_owned())
})?;
- let host = metadata.host.as_str();
- let port = metadata.port as u16;
Review Comment:
Now if there is a proxy the host/port is the proxy. Before it was using the
executor's host/port.
Just checking that this is intentional.
shuffle_reader::fetch_partition_remote() still uses the metadata host/port -
https://github.com/apache/datafusion-ballista/pull/1503/changes#diff-821d458bfa4b39a875e8889c8e93594de9ade9fe75ff4336198f51751527f73fR486
##########
ballista/core/src/config.rs:
##########
@@ -419,6 +427,23 @@ impl BallistaConfig {
v.parse::<f64>().unwrap()
}
}
+ /// sets the configuration value where key starts with ballista
+ /// prefix.
+ pub fn set_with_prefix(
+ &mut self,
+ key: &str,
+ value: &str,
+ ) -> datafusion::error::Result<()> {
+ let entries = Self::valid_entries();
+ //let k = format!("{}.{key}", BallistaConfig::PREFIX);
+
+ if entries.contains_key(key) {
+ self.settings.insert(key.to_string(), value.to_string());
Review Comment:
`with_settings()` does validation of the value -
https://github.com/apache/datafusion-ballista/pull/1503/changes#diff-62a06bd33b6bb8dba344edf9c08f6c41fcd3ff790d82c2157519cf46012a708aR221-R224
Is the same needed here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
