geoffreyclaude commented on PR #19390: URL: https://github.com/apache/datafusion/pull/19390#issuecomment-4054427179
@Dandandan and @adriangb : I've rebased my PR and tried to clean it up so it is reviewable commit by commit. I could have done 10 stacked PRs, but it seemed simpler and clearer to me to have a single common diff! What I'm mostly interested in right now is which optims you think are useful, and which are pushing it too far into micro-optimizations (hint hint: I'm looking at commit 6's custom hash table. It brings nice gains, but the maintenance cost is high.) Once we've settled that we can go a bit deeper into the actual code itself... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
