LiaCastaneda commented on issue #20899:
URL: https://github.com/apache/datafusion/issues/20899#issuecomment-4055100815
I think the only thing weird to me is that implementors will receive
preserve_properties and will have to do something different based on what value
it holds... 🤔
```
if preserve_properties {
recreate create node using new::
} else {
recreate node not using new::
}
```
considering that this method will be mandatory for each `ExecutionPlan`
I see other execution plan nodes have separate functions for explicitly not
recomputing properties, for example
[with_new_children_and_same_properties](https://github.com/apache/datafusion/blob/d2278a90b4543939cefb0f3ffbea8b025fe922f0/datafusion/physical-plan/src/limit.rs#L315)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
