Re: [PR] Add MultiDistinctToUnion optimizer rule for parallel distinct aggregates [datafusion]

Sat, 14 Mar 2026 01:10:51 -0700 


adriangbot commented on PR #20940:
URL: https://github.com/apache/datafusion/pull/20940#issuecomment-4059987594

   ๐Ÿค– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/20940#issuecomment-4059947897)
   
   <details><summary>Details</summary>
   <p>
   
   ```
   Comparing HEAD and multi-distinct-to-union
   --------------------
   Benchmark clickbench_extended.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query    โ”ƒ                                    HEAD โ”ƒ                   
multi-distinct-to-union โ”ƒ        Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 0 โ”‚      868.72 / 883.32 ยฑ15.10 / 910.39 ms โ”‚        529.35 / 
558.48 ยฑ21.42 / 592.18 ms โ”‚ +1.58x faster โ”‚
   โ”‚ QQuery 1 โ”‚       228.13 / 229.39 ยฑ1.30 / 231.56 ms โ”‚         204.65 / 
208.60 ยฑ2.30 / 210.71 ms โ”‚ +1.10x faster โ”‚
   โ”‚ QQuery 2 โ”‚       534.63 / 535.33 ยฑ0.48 / 536.14 ms โ”‚         529.52 / 
533.14 ยฑ3.00 / 536.94 ms โ”‚     no change โ”‚
   โ”‚ QQuery 3 โ”‚       332.54 / 333.57 ยฑ0.78 / 334.61 ms โ”‚         335.89 / 
338.00 ยฑ2.63 / 343.17 ms โ”‚     no change โ”‚
   โ”‚ QQuery 4 โ”‚      671.13 / 691.89 ยฑ12.82 / 703.04 ms โ”‚        690.63 / 
710.50 ยฑ14.61 / 727.56 ms โ”‚     no change โ”‚
   โ”‚ QQuery 5 โ”‚ 9666.38 / 9914.13 ยฑ142.81 / 10111.98 ms โ”‚ 10029.90 / 10119.15 
ยฑ135.48 / 10387.78 ms โ”‚     no change โ”‚
   โ”‚ QQuery 6 โ”‚   1003.30 / 1010.08 ยฑ10.25 / 1030.40 ms โ”‚      994.45 / 1010.25 
ยฑ12.36 / 1031.13 ms โ”‚     no change โ”‚
   โ”‚ QQuery 7 โ”‚      791.30 / 814.39 ยฑ14.18 / 831.49 ms โ”‚       827.78 / 880.70 
ยฑ76.41 / 1030.16 ms โ”‚  1.08x slower โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                      โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                      โ”‚ 14412.11ms โ”‚
   โ”‚ Total Time (multi-distinct-to-union)   โ”‚ 14358.81ms โ”‚
   โ”‚ Average Time (HEAD)                    โ”‚  1801.51ms โ”‚
   โ”‚ Average Time (multi-distinct-to-union) โ”‚  1794.85ms โ”‚
   โ”‚ Queries Faster                         โ”‚          2 โ”‚
   โ”‚ Queries Slower                         โ”‚          1 โ”‚
   โ”‚ Queries with No Change                 โ”‚          5 โ”‚
   โ”‚ Queries with Failure                   โ”‚          0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   </p>
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **clickbench_extended โ€” base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 72.7s |
   | Peak memory | 33.2 GiB |
   | Avg memory | 28.3 GiB |
   | CPU user | 719.6s |
   | CPU sys | 24.1s |
   | Disk read | 0 B |
   | Disk write | 22.5 MiB |
   
   **clickbench_extended โ€” branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 72.5s |
   | Peak memory | 34.2 GiB |
   | Avg memory | 27.5 GiB |
   | CPU user | 726.3s |
   | CPU sys | 29.0s |
   | Disk read | 0 B |
   | Disk write | 708.0 KiB |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to