comphead commented on code in PR #604:
URL: https://github.com/apache/datafusion-comet/pull/604#discussion_r1681577495
##########
native/core/benches/parquet_read.rs:
##########
@@ -54,7 +54,7 @@ fn bench(c: &mut Criterion) {
);
b.iter(|| {
let cd = ColumnDescriptor::new(t.clone(), 0, 0,
ColumnPath::from(Vec::new()));
- let promition_info = TypePromotionInfo::new(PhysicalType::INT32,
-1, -1);
+ let promition_info = TypePromotionInfo::new(PhysicalType::INT32,
-1, -1, 32);
Review Comment:
```suggestion
let promotion_info = TypePromotionInfo::new(PhysicalType::INT32,
-1, -1, 32);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
