Re: [PR] [Bench] Avoid concat_batches in hash join [datafusion]

Sat, 14 Mar 2026 23:57:33 -0700 


adriangbot commented on PR #20944:
URL: https://github.com/apache/datafusion/pull/20944#issuecomment-4062418541

   ๐Ÿค– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/20944#issuecomment-4062395363)
   
   <details><summary>Details</summary>
   <p>
   
   ```
   Comparing HEAD and avoid_concat
   --------------------
   Benchmark tpch_sf10.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query     โ”ƒ                               HEAD โ”ƒ                       
avoid_concat โ”ƒ       Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 1  โ”‚  381.81 / 386.30 ยฑ4.30 / 394.15 ms โ”‚  378.60 / 381.08 ยฑ2.05 / 
384.34 ms โ”‚    no change โ”‚
   โ”‚ QQuery 2  โ”‚  147.13 / 147.83 ยฑ0.44 / 148.38 ms โ”‚  148.63 / 152.13 ยฑ3.49 / 
157.32 ms โ”‚    no change โ”‚
   โ”‚ QQuery 3  โ”‚  298.46 / 300.71 ยฑ1.50 / 302.49 ms โ”‚  306.19 / 307.42 ยฑ1.29 / 
309.85 ms โ”‚    no change โ”‚
   โ”‚ QQuery 4  โ”‚  159.17 / 160.36 ยฑ0.96 / 162.06 ms โ”‚  160.01 / 161.25 ยฑ0.88 / 
162.60 ms โ”‚    no change โ”‚
   โ”‚ QQuery 5  โ”‚  435.36 / 444.26 ยฑ7.05 / 456.54 ms โ”‚  450.97 / 455.89 ยฑ2.72 / 
458.61 ms โ”‚    no change โ”‚
   โ”‚ QQuery 6  โ”‚  133.21 / 134.45 ยฑ0.98 / 135.74 ms โ”‚  134.50 / 135.46 ยฑ0.78 / 
136.82 ms โ”‚    no change โ”‚
   โ”‚ QQuery 7  โ”‚  584.45 / 591.27 ยฑ6.55 / 603.70 ms โ”‚  607.61 / 621.28 ยฑ8.07 / 
632.00 ms โ”‚ 1.05x slower โ”‚
   โ”‚ QQuery 8  โ”‚  490.92 / 495.54 ยฑ3.48 / 499.89 ms โ”‚  489.90 / 498.99 ยฑ5.67 / 
506.40 ms โ”‚    no change โ”‚
   โ”‚ QQuery 9  โ”‚  687.70 / 700.38 ยฑ9.42 / 715.34 ms โ”‚  700.10 / 714.63 ยฑ9.30 / 
727.53 ms โ”‚    no change โ”‚
   โ”‚ QQuery 10 โ”‚  331.33 / 342.31 ยฑ7.60 / 354.34 ms โ”‚  344.59 / 354.10 ยฑ9.76 / 
371.41 ms โ”‚    no change โ”‚
   โ”‚ QQuery 11 โ”‚  110.50 / 117.09 ยฑ5.26 / 126.01 ms โ”‚  122.49 / 125.93 ยฑ3.38 / 
131.91 ms โ”‚ 1.08x slower โ”‚
   โ”‚ QQuery 12 โ”‚  209.08 / 213.80 ยฑ2.53 / 216.54 ms โ”‚  207.38 / 210.44 ยฑ4.32 / 
218.82 ms โ”‚    no change โ”‚
   โ”‚ QQuery 13 โ”‚  322.05 / 324.22 ยฑ1.57 / 326.64 ms โ”‚  338.24 / 342.83 ยฑ3.23 / 
347.36 ms โ”‚ 1.06x slower โ”‚
   โ”‚ QQuery 14 โ”‚  184.47 / 185.97 ยฑ1.16 / 187.80 ms โ”‚  183.42 / 184.90 ยฑ1.23 / 
186.50 ms โ”‚    no change โ”‚
   โ”‚ QQuery 15 โ”‚  346.52 / 347.26 ยฑ0.63 / 348.14 ms โ”‚  338.49 / 339.71 ยฑ1.20 / 
341.94 ms โ”‚    no change โ”‚
   โ”‚ QQuery 16 โ”‚     91.51 / 93.26 ยฑ2.37 / 97.94 ms โ”‚     89.65 / 93.68 ยฑ2.34 / 
96.46 ms โ”‚    no change โ”‚
   โ”‚ QQuery 17 โ”‚ 797.68 / 810.10 ยฑ11.89 / 828.42 ms โ”‚  794.91 / 798.32 ยฑ2.01 / 
800.57 ms โ”‚    no change โ”‚
   โ”‚ QQuery 18 โ”‚ 826.98 / 894.88 ยฑ39.49 / 935.00 ms โ”‚  944.74 / 949.39 ยฑ5.62 / 
960.04 ms โ”‚ 1.06x slower โ”‚
   โ”‚ QQuery 19 โ”‚  270.36 / 277.80 ยฑ5.59 / 287.58 ms โ”‚  274.89 / 278.70 ยฑ2.87 / 
282.79 ms โ”‚    no change โ”‚
   โ”‚ QQuery 20 โ”‚  323.54 / 332.54 ยฑ5.50 / 339.28 ms โ”‚  330.08 / 332.98 ยฑ1.87 / 
335.00 ms โ”‚    no change โ”‚
   โ”‚ QQuery 21 โ”‚ 859.05 / 880.17 ยฑ11.41 / 889.95 ms โ”‚ 913.97 / 924.21 ยฑ14.51 / 
952.43 ms โ”‚ 1.05x slower โ”‚
   โ”‚ QQuery 22 โ”‚     83.63 / 86.64 ยฑ2.18 / 88.91 ms โ”‚     90.16 / 91.13 ยฑ0.60 / 
91.85 ms โ”‚ 1.05x slower โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary           โ”ƒ           โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)           โ”‚ 8267.14ms โ”‚
   โ”‚ Total Time (avoid_concat)   โ”‚ 8454.44ms โ”‚
   โ”‚ Average Time (HEAD)         โ”‚  375.78ms โ”‚
   โ”‚ Average Time (avoid_concat) โ”‚  384.29ms โ”‚
   โ”‚ Queries Faster              โ”‚         0 โ”‚
   โ”‚ Queries Slower              โ”‚         6 โ”‚
   โ”‚ Queries with No Change      โ”‚        16 โ”‚
   โ”‚ Queries with Failure        โ”‚         0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   </p>
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **tpch10 โ€” base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 41.7s |
   | Peak memory | 10.3 GiB |
   | Avg memory | 7.6 GiB |
   | CPU user | 434.6s |
   | CPU sys | 29.8s |
   | Disk read | 0 B |
   | Disk write | 2.9 GiB |
   
   **tpch10 โ€” branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 42.6s |
   | Peak memory | 10.0 GiB |
   | Avg memory | 7.7 GiB |
   | CPU user | 446.0s |
   | CPU sys | 28.8s |
   | Disk read | 0 B |
   | Disk write | 176.0 KiB |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to