neilconway commented on code in PR #20945:
URL: https://github.com/apache/datafusion/pull/20945#discussion_r2937712156
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -307,6 +307,34 @@ fn try_coerce_types(
)
}
+fn data_types_match(valid_types: &[DataType], current_types: &[DataType]) ->
bool {
Review Comment:
Ah, got it.
Just to help me understand, can you point at an SLT test (e.g., involving
structs) that would regress if we used `equals_datatype`? Or if such an SLT
test doesn't already exist, it would probably be a good idea to add one as a
sanity check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
