gabotechs commented on PR #20292: URL: https://github.com/apache/datafusion/pull/20292#issuecomment-4084665684
@xudong963 I in fact do not love the idea of computing the accuracy scores as I'm doing now, what I would have liked to do is to instead use `insta` assertions over the debug representation of the stats comparison. You have one example on the PR description. This is how I would have liked to do it https://github.com/apache/datafusion/pull/20292/commits/e912551bd2cd6d6089741036288fa91a78991097. It's a verbose assertion, but a pretty granular and useful one. The issue is that the results seem to be machine dependent: executing the tests on my Mac consistently passes the assertions, however, the same tests run on linux show significantly different results, so the CI will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
