adp2201 commented on issue #21038: URL: https://github.com/apache/datafusion/issues/21038#issuecomment-4085511524
My recommendation would be to document the PR flow first, and only add labels later if there is still a real gap. A lightweight documented flow like this would already help a lot: - Needs initial review - Waiting on author - Ready for re-review - Approved, waiting 24h - Ready to merge By “define the corresponding queries / saved searches”, I mean mapping each of those states to a GitHub PR search so people can quickly see the current list for that state without adding more process immediately. For example: - `Needs initial review` → open, non-draft PRs that are not yet approved - `Waiting on author` → PRs with requested changes / unresolved review feedback - `Ready for re-review` → PRs updated after review feedback - `Approved, waiting 24h` → approved PRs that are still inside the waiting window - `Ready to merge` → approved PRs past the waiting window I’d try that first using GitHub’s existing signals before adding labels. Labels can help, but they also create maintenance overhead, and stale labels can make things less clear rather than more clear. So my preference would be: 1. document the states 2. define the matching queries / saved searches 3. add labels only if there is a state GitHub cannot represent clearly enough on its own -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
