andygrove commented on code in PR #676:
URL: https://github.com/apache/datafusion-comet/pull/676#discussion_r1682062114
##########
dev/diffs/3.5.1.diff:
##########
@@ -2120,29 +2120,17 @@ index 746f289c393..bc01ffd52ea 100644
checkAnswer(aggDF, df1.groupBy("j").agg(max("k")))
}
}
-@@ -1013,7 +1039,9 @@ abstract class BucketedReadSuite extends QueryTest with
SQLTestUtils with Adapti
- }
- }
-
-- test("bucket coalescing is applied when join expressions match with
partitioning expressions") {
-+ // https://github.com/apache/datafusion-comet/issues/617
-+ test("bucket coalescing is applied when join expressions match with
partitioning expressions",
-+ IgnoreComet("TODO: fix Comet for this test")) {
- withTable("t1", "t2", "t3") {
- df1.write.format("parquet").bucketBy(8, "i", "j").saveAsTable("t1")
- df2.write.format("parquet").bucketBy(4, "i", "j").saveAsTable("t2")
-@@ -1029,15 +1057,23 @@ abstract class BucketedReadSuite extends QueryTest
with SQLTestUtils with Adapti
+@@ -1029,15 +1055,23 @@ abstract class BucketedReadSuite extends QueryTest
with SQLTestUtils with Adapti
Seq(true, false).foreach { aqeEnabled =>
withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key ->
aqeEnabled.toString) {
val plan = sql(query).queryExecution.executedPlan
- val shuffles = collect(plan) { case s: ShuffleExchangeExec => s
}
+ val shuffles = collect(plan) {
-+ case s: ShuffleExchangeLike => s
-+ }
++ case s: ShuffleExchangeLike => s
++ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
