Dandandan commented on PR #21023: URL: https://github.com/apache/datafusion/pull/21023#issuecomment-4089473795
> @Dandandan made the changes based on your feedback. The clickbench test seems to have a determinism issue, should I handle it here? Don't worry about clickbench - it does sometimes finish a bit more quickly than in other cases. But it doesn't have any joins. The regressions in tpcds_sf1 I also saw in my branch, would be nice to find out if we can minimize them (although I think it would be acceptable to have some low % losses for improving `Query 99 ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
