andygrove commented on code in PR #3732:
URL: https://github.com/apache/datafusion-comet/pull/3732#discussion_r2963306733
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2992,4 +2992,27 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("window_time") {
+ withTable("t1") {
+ sql("create table t1(time timestamp, value int) using parquet")
+ sql(
+ "insert into t1 values" +
+ "(cast('2023-01-01 12:00:00' as timestamp), 1)," +
+ "(cast('2023-01-01 12:05:00' as timestamp), 2)," +
+ "(cast('2023-01-01 12:15:00' as timestamp), 3)")
+
+ // basic window_time with aggregation
+ checkSparkAnswer(
Review Comment:
`checkSparkAnswer` isn't checking that the query is actually running in
Comet. However, it would be better to add the SQL based tests instead as
@comphead pointed out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
