timsaucer commented on code in PR #1391:
URL:
https://github.com/apache/datafusion-python/pull/1391#discussion_r2965763129
##########
Cargo.toml:
##########
@@ -70,12 +70,12 @@ codegen-units = 1
# We cannot publish to crates.io with any patches in the below section.
Developers
# must remove any entries in this section before creating a release candidate.
[patch.crates-io]
-datafusion = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-substrait = { git = "https://github.com/apache/datafusion.git";, rev
= "35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-proto = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-ffi = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-catalog = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-common = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-functions-aggregate = { git =
"https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-functions-window = { git =
"https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
-datafusion-expr = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f", submodules = false }
+datafusion = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-substrait = { git = "https://github.com/apache/datafusion.git";, rev
= "35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-proto = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-ffi = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-catalog = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-common = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-functions-aggregate = { git =
"https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-functions-window = { git =
"https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
+datafusion-expr = { git = "https://github.com/apache/datafusion.git";, rev =
"35749607f585b3bf25b66b7d2289c56c18d03e4f" }
Review Comment:
It turns out specifying submodules in patch is not supported, so this
generates a warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
